An important announcement from the founder of property-bee.com: The future of Property Bee is assured.

Bug #187 - CSS Conflict

An area to discuss the development and technical aspects of the toolbar

Bug #187 - CSS Conflict

Postby s-p on Tue Dec 21, 2010 10:24 pm

Before I commit a code change to resolve this, can I just run the adjustment by you Beerhunter if that's ok?

There's an interesting comment that makes me query why the fix isn't already in 2.0.8.1! :lol:

Offending Code: firefox.css
Code: Select all
bh (11/12/2010)
Not used within PB itself but modifies firefox styling to allow sidebars to widen more than ~400px.
After lots of googling, it appears its a css namespace issue (didn't even know they existed!). Even tho
this file is loaded as an "agent" (ie firefox) stylesheet also affects the appear of webpages! See
https://developer.mozilla.org/en/Using_the_Stylesheet_Service. Adding @namespace
url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"); seems to fix the problem.
I wonder if the stylesheets toolbar.css and sidebar.css also need this?


Given that comment, I would have assumed that a namespace declaration would have been made somewhere in the firefox.css file? Either way, can you confirm that this is the sort of change you would have expected?

Code: Select all
[b]@namespace PB "http://propertybee.com"[/b]

[b]PB|[/b]#sidebar-box {
   overflow-x: hidden !important;
}

[b]PB|[/b]#sidebar {
   min-width: 0px !important;
   max-width: none !important;
   overflow-x: hidden !important;
}


Mantis Link: http://www.property-bee.com/development/bugs/view.php?id=187
Scott
s-p
 
Posts: 125
Joined: Mon Jun 09, 2008 10:20 pm

Re: Bug #187 - CSS Conflict

Postby Beerhunter on Wed Dec 22, 2010 1:36 am

Ah #@*%~!

Seems I managed to commit the file without the change I proposed, but did uncomment the css.... corrected in revision 191.
User avatar
Beerhunter
Site Admin
 
Posts: 1788
Joined: Tue Jan 22, 2008 12:05 am


Return to Development

Who is online

Users browsing this forum: No registered users and 7 guests

cron